Simple-Web-Server: Difference between revisions
No edit summary |
No edit summary |
||
Line 21: | Line 21: | ||
git rebase eidheim-upstream/master # rebase your branch, so upstream is preserved even if there are commits (there should NOT be!) | git rebase eidheim-upstream/master # rebase your branch, so upstream is preserved even if there are commits (there should NOT be!) | ||
git push | git push | ||
--- | |||
# on bitpost, push the mirror | |||
cd development/thedigitalage/Simple-Web-Server.git | |||
git push | |||
* to put together a pull request to send to Ole, first get all upstream changes, then create a new branch off of my fork's master, push the new branch to my fork, and use GitHub to create the pull request | * to put together a pull request to send to Ole, first get all upstream changes, then create a new branch off of my fork's master, push the new branch to my fork, and use GitHub to create the pull request | ||
# follow above steps to ensure my fork has latest changes from Ole; then... | # follow above steps to ensure my fork has latest changes from Ole; then... |
Revision as of 17:14, 21 August 2016
The best C++ https code I found during my 2016/08 search. Ole Christian Eidheim, the author, is great, he answered my emails and accepted my pull requests.
Security Concerns
- I'm contributing to keep SWS ciphers etc. up-to-date so it can maintain an A on its ssl tests.
- This blog entry has been kept up to date with recommendations and solutions.
- Use nothing older than tlsv12. Pull request applied, fixed.
- Use AES not RC4. This requires setting OpenSSL options. Ole advised on how to update the ciphers. I'm investigating.
- Need HSTS headers to allow perfect forward secrecy.
Repo structure
- upstream
- my fork
- my bare shared mirror of my fork: bitpost: development/thedigitalage/Simple-Web-Server.git
- my dev clones: development/thedigitalage/Simple-Web-Server
- to get upstream changes, just copy+paste all this goo:
cd development/thedigitalage/Simple-Web-Server # any dev clone will do # make sure it has the upstream available - only do this once # git remote add eidheim-upstream https://github.com/eidheim/Simple-Web-Server.git git fetch eidheim-upstream git checkout master git rebase eidheim-upstream/master # rebase your branch, so upstream is preserved even if there are commits (there should NOT be!) git push --- # on bitpost, push the mirror cd development/thedigitalage/Simple-Web-Server.git git push
- to put together a pull request to send to Ole, first get all upstream changes, then create a new branch off of my fork's master, push the new branch to my fork, and use GitHub to create the pull request
# follow above steps to ensure my fork has latest changes from Ole; then... git checkout master && git pull git checkout -b new-feature-name # work work work git push --set-upstream origin new-feature-name # use GitHub to create a pull request
AES discussion
eidheim commented 3 hours ago I found only this: https://github.com/zaphoyd/websocketpp/blob/master/examples/echo_server_tls/echo_server_tls.cpp#L124. Here OpenSSL is used directly to disable RC4 I think (...:!RC4:...). See here for documentation of the command: https://www.openssl.org/docs/manmaster/ssl/SSL_CTX_set_cipher_list.html. The SSL_CTX* is reached by doing context.native_handle() in https_server.hpp if I'm not mistaken. Although which ciphers should be included otherwise I'm not sure of, however, it should be possible to receive the cipher list from SSL_CTX_get_ciphers (https://www.openssl.org/docs/manmaster/ssl/SSL_get_ciphers.html), that is instead of hardcoding them like in https://github.com/zaphoyd/websocketpp/blob/master/examples/echo_server_tls/echo_server_tls.cpp#L124. @moodboom
moodboom commented 3 hours ago Cool. Here's the analysis that led me to think AES was the correct choice:
https://hynek.me/articles/hardening-your-web-servers-ssl-ciphers/
I'll try hardcoding a recommended cipher from there as the default and see what I get. If that works, maybe we can provide a cipher option to the user?
Including support for HSTS seems to be the other important concern.